linux-hardening - Re: [PATCH] ACPI / sysfs: Replace deprecated and unsafe functions with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202506261036.895ef959-lkp@intel.com>
Date: Thu, 26 Jun 2025 10:51:07 +0800
From: kernel test robot <oliver.sang@...el.com>
To: Brahmajit Das <listout@...tout.xyz>
CC: <oe-lkp@...ts.linux.dev>, <lkp@...el.com>, <linux-acpi@...r.kernel.org>,
	<linux-hardening@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<rafael@...nel.org>, <lenb@...nel.org>, <lv.zheng@...el.com>,
	<kees@...nel.org>, <rui.zhang@...el.com>, <len.brown@...el.com>,
	<oliver.sang@...el.com>
Subject: Re: [PATCH] ACPI / sysfs: Replace deprecated and unsafe functions
 with sysfs_emit



Hello,

kernel test robot noticed "WARNING:at_fs/sysfs/file.c:#sysfs_emit" on:

commit: 74191212ddb1a82ed54ddd75fcd820f3df79abef ("[PATCH] ACPI / sysfs: Replace deprecated and unsafe functions with sysfs_emit")
url: https://github.com/intel-lab-lkp/linux/commits/Brahmajit-Das/ACPI-sysfs-Replace-deprecated-and-unsafe-functions-with-sysfs_emit/20250624-213919
base: https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/all/20250624133739.25215-1-listout@listout.xyz/
patch subject: [PATCH] ACPI / sysfs: Replace deprecated and unsafe functions with sysfs_emit

in testcase: boot

config: x86_64-rhel-9.4
compiler: gcc-12
test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G

(please refer to attached dmesg/kmsg for entire log/backtrace)


+----------------------------------------+------------+------------+
|                                        | 3cd1e195f0 | 74191212dd |
+----------------------------------------+------------+------------+
| WARNING:at_fs/sysfs/file.c:#sysfs_emit | 0          | 18         |
| RIP:sysfs_emit                         | 0          | 18         |
+----------------------------------------+------------+------------+


If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <oliver.sang@...el.com>
| Closes: https://lore.kernel.org/oe-lkp/202506261036.895ef959-lkp@intel.com


[    0.410439][    T1] ------------[ cut here ]------------
[    0.410995][    T1] invalid sysfs_emit: buf:(____ptrval____)
[ 0.411411][ T1] WARNING: CPU: 0 PID: 1 at fs/sysfs/file.c:767 sysfs_emit (fs/sysfs/file.c:767) 
[    0.412230][    T1] Modules linked in:
[    0.412660][    T1] CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.16.0-rc3-00031-g74191212ddb1 #1 VOLUNTARY
[    0.413504][    T1] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
[ 0.414499][ T1] RIP: 0010:sysfs_emit (fs/sysfs/file.c:767) 
[ 0.415012][ T1] Code: 10 e8 d5 8e b4 00 48 8b 54 24 18 65 48 2b 15 40 f5 69 02 75 1b c9 e9 d0 7c b6 00 48 89 fe 48 c7 c7 d9 be b6 ae e8 71 86 b3 ff <0f> 0b 31 c0 eb d6 e8 a6 88 b5 00 66 66 2e 0f 1f 84 00 00 00 00 00
All code
========
   0:	10 e8                	adc    %ch,%al
   2:	d5                   	(bad)
   3:	8e b4 00 48 8b 54 24 	mov    0x24548b48(%rax,%rax,1),%?
   a:	18 65 48             	sbb    %ah,0x48(%rbp)
   d:	2b 15 40 f5 69 02    	sub    0x269f540(%rip),%edx        # 0x269f553
  13:	75 1b                	jne    0x30
  15:	c9                   	leave
  16:	e9 d0 7c b6 00       	jmp    0xb67ceb
  1b:	48 89 fe             	mov    %rdi,%rsi
  1e:	48 c7 c7 d9 be b6 ae 	mov    $0xffffffffaeb6bed9,%rdi
  25:	e8 71 86 b3 ff       	call   0xffffffffffb3869b
  2a:*	0f 0b                	ud2		<-- trapping instruction
  2c:	31 c0                	xor    %eax,%eax
  2e:	eb d6                	jmp    0x6
  30:	e8 a6 88 b5 00       	call   0xb588db
  35:	66 66 2e 0f 1f 84 00 	data16 cs nopw 0x0(%rax,%rax,1)
  3c:	00 00 00 00 

Code starting with the faulting instruction
===========================================
   0:	0f 0b                	ud2
   2:	31 c0                	xor    %eax,%eax
   4:	eb d6                	jmp    0xffffffffffffffdc
   6:	e8 a6 88 b5 00       	call   0xb588b1
   b:	66 66 2e 0f 1f 84 00 	data16 cs nopw 0x0(%rax,%rax,1)
  12:	00 00 00 00 
[    0.415674][    T1] RSP: 0000:ffffcdc1c0013cb8 EFLAGS: 00010282
[    0.416230][    T1] RAX: 0000000000000000 RBX: 0000000000000000 RCX: c0000000ffff7fff
[    0.417231][    T1] RDX: 0000000000000000 RSI: 00000000ffff7fff RDI: ffffffffaee63ba0
[    0.418233][    T1] RBP: ffffcdc1c0013d08 R08: 0000000000000000 R09: 0000000000000003
[    0.419233][    T1] R10: ffffcdc1c0013b58 R11: ffffffffaf1e3be8 R12: ffff8c28408940a0
[    0.420232][    T1] R13: ffffffffadb37cd0 R14: 00000000000004e5 R15: 0000000000000000
[    0.421234][    T1] FS:  0000000000000000(0000) GS:ffff8c2bbfdce000(0000) knlGS:0000000000000000
[    0.422237][    T1] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    0.423179][    T1] CR2: ffff8c2b7ffff000 CR3: 000000010f024000 CR4: 00000000000406f0
[    0.423631][    T1] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[    0.424609][    T1] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[    0.425613][    T1] Call Trace:
[    0.426168][    T1]  <TASK>
[ 0.426431][ T1] acpi_irq_stats_init (drivers/acpi/sysfs.c:887) 
[ 0.427234][ T1] ? acpi_os_signal_semaphore (drivers/acpi/osl.c:1320) 
[ 0.428079][ T1] ? acpi_ut_release_mutex (drivers/acpi/acpica/utmutex.c:329) 
[ 0.428478][ T1] acpi_os_install_interrupt_handler (drivers/acpi/osl.c:568) 
[ 0.429235][ T1] ? __pfx_acpi_init (drivers/acpi/bus.c:1440) 
[ 0.429990][ T1] acpi_ev_install_xrupt_handlers (drivers/acpi/acpica/evevent.c:95) 
[ 0.430500][ T1] ? __pfx_acpi_init (drivers/acpi/bus.c:1440) 
[ 0.431233][ T1] acpi_bus_init (drivers/acpi/bus.c:1362) 
[ 0.431971][ T1] ? acpi_ut_release_mutex (drivers/acpi/acpica/utmutex.c:329) 
[ 0.432485][ T1] ? acpi_install_address_space_handler_internal+0x64/0xb0 
[ 0.433605][ T1] ? __pfx_acpi_init (drivers/acpi/bus.c:1440) 
[ 0.434234][ T1] ? __pfx_acpi_init (drivers/acpi/bus.c:1440) 
[ 0.434989][ T1] acpi_init (drivers/acpi/bus.c:1456) 
[ 0.435382][ T1] ? __pfx_scan_for_dmi_ipmi (drivers/char/ipmi/ipmi_dmi.c:215) 
[ 0.435948][ T1] ? __pfx_acpi_init (drivers/acpi/bus.c:1440) 
[ 0.436380][ T1] do_one_initcall (init/main.c:1274) 
[ 0.436875][ T1] do_initcalls (init/main.c:1335 init/main.c:1352) 
[ 0.437233][ T1] kernel_init_freeable (init/main.c:1588) 
[ 0.437770][ T1] ? __pfx_kernel_init (init/main.c:1466) 
[ 0.438231][ T1] kernel_init (init/main.c:1476) 
[ 0.438714][ T1] ret_from_fork (arch/x86/kernel/process.c:154) 
[ 0.439203][ T1] ? __pfx_kernel_init (init/main.c:1466) 
[ 0.439386][ T1] ret_from_fork_asm (arch/x86/entry/entry_64.S:258) 
[    0.439885][    T1]  </TASK>
[    0.440230][    T1] ---[ end trace 0000000000000000 ]---


The kernel config and materials to reproduce are available at:
https://download.01.org/0day-ci/archive/20250626/202506261036.895ef959-lkp@intel.com



-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki