linux-hardening - Re: [PATCH v16 1/5] dt-bindings: mmc: sdhci-pxa: restrict pinctrl to pxav1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3379810.44csPzL39Z@radijator>
Date: Wed, 09 Jul 2025 19:33:01 +0200
From: Duje Mihanović <duje@...emihanovic.xyz>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Lubomir Rintel <lkundrak@...sk>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Andrew Lunn <andrew@...n.ch>, Gregory Clement <gregory.clement@...tlin.com>,
 Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
 Kees Cook <kees@...nel.org>, Tony Luck <tony.luck@...el.com>,
 "Guilherme G. Piccoli" <gpiccoli@...lia.com>,
 Ulf Hansson <ulf.hansson@...aro.org>, David Wronek <david@...nlining.org>,
 Karel Balej <balejk@...fyz.cz>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-hardening@...r.kernel.org, phone-devel@...r.kernel.org,
 ~postmarketos/upstreaming@...ts.sr.ht, soc@...ts.linux.dev,
 linux-mmc@...r.kernel.org
Subject:
 Re: [PATCH v16 1/5] dt-bindings: mmc: sdhci-pxa: restrict pinctrl to pxav1

On Wednesday, 9 July 2025 09:32:06 Central European Summer Time Krzysztof 
Kozlowski wrote:
> On Tue, Jul 08, 2025 at 07:09:46PM +0200, Duje Mihanović wrote:
> > The current pinctrl properties apply only to the pxav1 controller.
> 
> Why they are not applicable for pxav3?

state_cmd_gpio is used for working around a PXA168 SDIO erratum. That SoC uses 
the pxav1 controller and no such erratum exists on any of the other PXA SoCs.

> > Adding one default pinctrl node to a pxav3 controller therefore causes
> > a schema warning.
> > 
> > Check the existing properties only on pxav1. pxav2 and pxav3 may add
> > their own set of pinctrl properties if and when needed.
> 
> This should be rather made complete here, because properties should be
> defined in top-level, not in allOf: block. Strictly speaking pinctrl-xxx
> are defined in core schema, but still the binding should follow same
> rule - define them in top.

Would it then be acceptable to declare the pinctrl properties in the top level 
and define each controller's respective description: and items: in the allOf: 
block?

Regards,
--
Duje