linux-hardening - Re: [PATCH v3 01/15] lib: provide kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c7edf57-bf13-4633-8348-791e0620cc79@lucifer.local>
Date: Thu, 24 Jul 2025 12:15:11 +0100
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Bartosz Golaszewski <brgl@...ev.pl>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>,
        Alexey Klimov <alexey.klimov@...aro.org>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Sean Wang <sean.wang@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
        Paul Cercueil <paul@...pouillou.net>, Kees Cook <kees@...nel.org>,
        Andy Shevchenko <andy@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Hildenbrand <david@...hat.com>,
        "Liam R. Howlett" <Liam.Howlett@...cle.com>,
        Vlastimil Babka <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>,
        Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>,
        Dong Aisheng <aisheng.dong@....com>,
        Fabio Estevam <festevam@...il.com>, Shawn Guo <shawnguo@...nel.org>,
        Jacky Bai <ping.bai@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP S32 Linux Team <s32@....com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Tony Lindgren <tony@...mide.com>,
        Haojian Zhuang <haojian.zhuang@...aro.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-mips@...r.kernel.org,
        linux-hardening@...r.kernel.org, linux-mm@...ck.org,
        imx@...ts.linux.dev, linux-omap@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v3 01/15] lib: provide kmemdup_const()

On Thu, Jul 24, 2025 at 01:12:49PM +0200, Andy Shevchenko wrote:
> On Thu, Jul 24, 2025 at 1:10 PM Lorenzo Stoakes
> <lorenzo.stoakes@...cle.com> wrote:
> > On Thu, Jul 24, 2025 at 11:24:29AM +0200, Bartosz Golaszewski wrote:
> > > +extern const void *kmemdup_const(const void *src, size_t len, gfp_t gfp);
> >
> > Please drop extern, it's unnecessary.
>
> It's all over the header. This should be done as a precursor patch and
> I know that usually people push back on doing that. I gave up on this.
> Kernel is going to rot sooner or later... :-(

In mm we just update as we go, this is probably the best approach to avoid
unnecessary churn.