linux-hardening - Re: [PATCH] kcsan: test: Replace deprecated strcpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6BC1BD59-839C-4A3B-AE91-8CE963C891AA@linux.dev>
Date: Mon, 18 Aug 2025 21:32:01 +0200
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: Justin Stitt <justinstitt@...gle.com>
Cc: Marco Elver <elver@...gle.com>,
 Dmitry Vyukov <dvyukov@...gle.com>,
 linux-hardening@...r.kernel.org,
 kasan-dev@...glegroups.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kcsan: test: Replace deprecated strcpy() with strscpy()

On 18. Aug 2025, at 20:26, Justin Stitt wrote:
> Looks good.
> 
> Here's my checklist:
> 1) strcpy() and strscpy() have differing return values, but we aren't using
> it.
> 2) strscpy() can fail with -E2BIG if source is too big, but it isn't in
> this case.
> 3) two-arg version of strscpy() is OK to use here as the source has a known
> size at compile time.
> 
> Reviewed-by: Justin Stitt <justinstitt@...gle.com>

Thanks for your thorough review.

Thorsten