linux-hardening - Re: [PATCH 4/4] kdb: Replace deprecated strcpy() with helper function in kdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <33D2B62D-9052-42A8-AB66-DF2903BBA52F@linux.dev>
Date: Mon, 18 Aug 2025 22:59:35 +0200
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: Doug Anderson <dianders@...omium.org>
Cc: Jason Wessel <jason.wessel@...driver.com>,
 Daniel Thompson <danielt@...nel.org>,
 Nir Lichtman <nir@...htman.org>,
 Yuran Pereira <yuran.pereira@...mail.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Zhang Heng <zhangheng@...inos.cn>,
 "Dr. David Alan Gilbert" <linux@...blig.org>,
 linux-hardening@...r.kernel.org,
 Daniel Thompson <daniel@...cstar.com>,
 kgdb-bugreport@...ts.sourceforge.net,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] kdb: Replace deprecated strcpy() with helper function
 in kdb_defcmd()

On 18. Aug 2025, at 22:42, Doug Anderson wrote:
>> +	memcpy(s, str, len);
>> +	s[len - 1] = '\0';
> 
> Very nitty, but technically the above memcpy() could pass "len - 1", right?

Ah yes, I missed this after adding the manual NUL-termination.

I'll send a v2 tomorrow.

> It doesn't really matter other than the wasteful copy of 1-byte, so:
> 
> Reviewed-by: Douglas Anderson <dianders@...omium.org>

Thanks,
Thorsten