linux-hardening - Re: [PATCH][next] scsi: fc: Avoid -Wflex-array-member-not-at-end warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABPRKS9BVsGhBDmNVbts9QhMsJ-mZhMKDB4u-NnfVcVLsfWrAg@mail.gmail.com>
Date: Tue, 26 Aug 2025 16:13:38 -0700
From: Justin Tee <justintee8345@...il.com>
To: "Martin K. Petersen" <martin.petersen@...cle.com>, 
	"Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc: James Smart <james.smart@...adcom.com>, Justin Tee <justin.tee@...adcom.com>, 
	Hannes Reinecke <hare@...e.de>, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] scsi: fc: Avoid -Wflex-array-member-not-at-end warnings

Hi Martin and Gustavo,

Regarding the maintainers file, yes Broadcom will push a patch to update soon.

Regarding Gustavo’s patch, I think we should also update the
assignment of rdf.desc_len in lpfc_els.c like below.

diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index fca81e0c7c2e..432761fb49de 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -3762,7 +3762,7 @@ lpfc_issue_els_rdf(struct lpfc_vport *vport,
uint8_t retry)
        memset(prdf, 0, cmdsize);
        prdf->rdf.fpin_cmd = ELS_RDF;
        prdf->rdf.desc_len = cpu_to_be32(sizeof(struct lpfc_els_rdf_req) -
-                                        sizeof(struct fc_els_rdf));
+                                        sizeof(struct fc_els_rdf_hdr));
        prdf->reg_d1.reg_desc.desc_tag = cpu_to_be32(ELS_DTAG_FPIN_REGISTER);
        prdf->reg_d1.reg_desc.desc_len = cpu_to_be32(
                                FC_TLV_DESC_LENGTH_FROM_SZ(prdf->reg_d1));

Thanks,
Justin Tee