linux-hardening - Re: [PATCH] iwlegacy: Remove unused structs and avoid -Wflex-array-member-not-at-end warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2b54967e-bd1f-4ad9-bba7-aa05bf3d1e7c@embeddedor.com>
Date: Wed, 27 Aug 2025 12:05:18 +0200
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: Johannes Berg <johannes@...solutions.net>,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>,
 Stanislaw Gruszka <stf_xl@...pl>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH] iwlegacy: Remove unused structs and avoid
 -Wflex-array-member-not-at-end warnings

On 27/08/25 11:36, Johannes Berg wrote:
> On Wed, 2025-08-27 at 11:25 +0200, Gustavo A. R. Silva wrote:
>> Friendly
> 
> I contest that. It's been two weeks, while it's still summer with

Sorry, I don't really know when people around the globe are on vacation
or not. I don't think we're based in the same area, so our customs may
vary.

> vacations etc., not long after the merge window closed, with weeks to go
> until the next release comes around. Why are you impatient?

Apparently (and according to git blame), the last person that committed a
change to this file was Greg KH back in 2019, see: commit 16da78b7b580e
("treewide: Replace GPLv2 boilerplate/ reference with SPDX - rule 270").

So, rather than impatience is more about not really knowing who's maintaining
this file.

> 
> I will take it. Eventually, the more you push the less I want to. And

Not sure what to make of this. I'm just doing my work and trying to
collaborate with people. I expect all my comments here clarify the
reason for the ping.

> it'd help if you actually followed our conventions and used 'wifi:'
> prefix.

Related to my comments above, you're not listed as a maintainer of this
file. If you were, I'd have probably remembered that.

scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h
Stanislaw Gruszka <stf_xl@...pl> (maintainer:INTEL WIRELESS 3945ABG/BG, 4965AGN (iwlegacy))
linux-wireless@...r.kernel.org (open list:INTEL WIRELESS 3945ABG/BG, 4965AGN (iwlegacy))
linux-kernel@...r.kernel.org (open list)
INTEL WIRELESS 3945ABG/BG, 4965AGN (iwlegacy) status: Supported

In any case, thanks for your response.
-Gustavo