linux-hardening - Re: [PATCH] arm64: mm: Fix CFI failure due to kpti_ng_pgd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <315CE055-A886-4322-9683-AFE7003B1664@kernel.org>
Date: Fri, 29 Aug 2025 12:41:07 -0400
From: Kees Cook <kees@...nel.org>
To: Mark Rutland <mark.rutland@....com>, Kevin Brodsky <kevin.brodsky@....com>
CC: Ard Biesheuvel <ardb@...nel.org>, Catalin Marinas <catalin.marinas@....com>,
 Will Deacon <will@...nel.org>, Oliver Upton <oliver.upton@...ux.dev>,
 Anshuman Khandual <anshuman.khandual@....com>,
 Yue Haibing <yuehaibing@...wei.com>, Marc Zyngier <maz@...nel.org>,
 Mark Brown <broonie@...nel.org>, linux-arm-kernel@...ts.infradead.org,
 Ryan Roberts <ryan.roberts@....com>,
 Shameer Kolothum <shameerali.kolothum.thodi@...wei.com>,
 Joey Gouly <joey.gouly@....com>, Yeoreum Yun <yeoreum.yun@....com>,
 James Morse <james.morse@....com>,
 Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>,
 Andrew Morton <akpm@...ux-foundation.org>,
 David Hildenbrand <david@...hat.com>,
 Zhenhua Huang <quic_zhenhuah@...cinc.com>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, Dev Jain <dev.jain@....com>,
 Yicong Yang <yangyicong@...ilicon.com>, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH] arm64: mm: Fix CFI failure due to kpti_ng_pgd_alloc function signature



On August 29, 2025 12:06:17 PM EDT, Mark Rutland <mark.rutland@....com> wrote:
>On Fri, Aug 29, 2025 at 08:49:21AM -0700, Kees Cook wrote:
>> Fixes: 47546a1912fc ("arm64: mm: install KPTI nG mappings with MMU enabled")
>
>That doesn't look right; that commit is from June 2022, and we only
>introduced enum pgtable_type in May 2025 in commit:
>
>  c64f46ee13779616 ("arm64: mm: use enum to identify pgtable level instead of *_SHIFT")
>
>... which landed in v6.16.
>
>AFAICT, that's the commit which broke things.

Oops, yes, I didn't look close enough. Want a v2 with that fixed up?


-- 
Kees Cook