linux-hardening - Re: [PATCH v3 01/10] dt-bindings: gpu: mali-valhall-csf: add mediatek,mt8196-mali variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <175812136009.2068624.13991293282844294346.robh@kernel.org>
Date: Wed, 17 Sep 2025 10:02:40 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Nicolas Frattaroli <nicolas.frattaroli@...labora.com>
Cc: Kyungmin Park <kyungmin.park@...sung.com>, 
 Jassi Brar <jassisinghbrar@...il.com>, Kees Cook <kees@...nel.org>, 
 Chia-I Wu <olvaffe@...il.com>, Matthias Brugger <matthias.bgg@...il.com>, 
 linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org, 
 Thomas Zimmermann <tzimmermann@...e.de>, Conor Dooley <conor+dt@...nel.org>, 
 Chanwoo Choi <cw00.choi@...sung.com>, Simona Vetter <simona@...ll.ch>, 
 linux-arm-kernel@...ts.infradead.org, 
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
 linux-pm@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
 Maxime Ripard <mripard@...nel.org>, Steven Price <steven.price@....com>, 
 David Airlie <airlied@...il.com>, Chen-Yu Tsai <wenst@...omium.org>, 
 MyungJoo Ham <myungjoo.ham@...sung.com>, kernel@...labora.com, 
 Boris Brezillon <boris.brezillon@...labora.com>, 
 linux-hardening@...r.kernel.org, 
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
 devicetree@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 "Gustavo A. R. Silva" <gustavoars@...nel.org>, 
 Liviu Dudau <liviu.dudau@....com>
Subject: Re: [PATCH v3 01/10] dt-bindings: gpu: mali-valhall-csf: add
 mediatek,mt8196-mali variant

On Wed, 17 Sep 2025 14:22:32 +0200, Nicolas Frattaroli wrote:
> The Mali-based GPU on the MediaTek MT8196 SoC uses a separate MCU to
> control the power and frequency of the GPU.
> 
> It lets us omit the OPP tables from the device tree, as those can now be
> enumerated at runtime from the MCU. It also means the mali GPU node
> described in this binding does not have any clocks in this case, as all
> clock control is delegated to the MCU.
> 
> Add the mediatek,mt8196-mali compatible, and a performance-domains
> property which points to the MCU's device tree node in this case. It's
> required on mt8196 devices.
> 
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@...labora.com>
> ---
>  .../bindings/gpu/arm,mali-valhall-csf.yaml         | 32 ++++++++++++++++++++--
>  1 file changed, 30 insertions(+), 2 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.example.dtb: gpu@...00000 (mediatek,mt8196-mali): 'clocks' is a required property
	from schema $id: http://devicetree.org/schemas/gpu/arm,mali-valhall-csf.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250917-mt8196-gpufreq-v3-1-c4ede4b4399e@collabora.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.