linux-hardening - Re: [PATCH] Revert "scsi: qla2xxx: Fix memcpy() field-spanning write issue"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fbbef12e-fc43-464f-b92d-f42f3692a46c@redhat.com>
Date: Thu, 25 Sep 2025 10:18:09 -0400
From: John Meneghini <jmeneghi@...hat.com>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>, martin.petersen@...cle.com
Cc: axboe@...nel.dk, bgurney@...hat.com, emilne@...hat.com,
 gustavoars@...nel.org, hare@...e.de, hch@....de, james.smart@...adcom.com,
 kbusch@...nel.org, kees@...nel.org, linux-hardening@...r.kernel.org,
 linux-nvme@...ts.infradead.org, linux-scsi@...r.kernel.org,
 njavali@...vell.com, sagi@...mberg.me
Subject: Re: [PATCH] Revert "scsi: qla2xxx: Fix memcpy() field-spanning write
 issue"

On 9/25/25 9:38 AM, Gustavo A. R. Silva wrote: 
> On 9/25/25 15:07, John Meneghini wrote:
>> This reverts commit 6f4b10226b6b1e7d1ff3cdb006cf0f6da6eed71e.
>>
>> We've been testing this patch and it turns out there is a significant
>> bug here. This leaks memory and causes a driver hang.
>>
>> Link:
>> https://lore.kernel.org/linux-scsi/yq1zfajqpec.fsf@ca-mkp.ca.oracle.com/
> 
> Thanks for the report. I wonder if you have any logs or something I could
> look at to figure out what's going on.

We have a fix already.  Chris and Bryan figured it out.

> Bryan,
> 
> Could you please share how this patch[1] was tested?

Bryan, please reply with bug fix patch you emailed me yesterday as an RFC patch.

Gustavo, this patch is being tested as a part of our FPIN LI changes. To run this code you need a Brocade switch and a whole lot of hardware.

You can see a example test plan here: https://bugzilla.kernel.org/attachment.cgi?id=308368&action=view

I am about to submit a version 10 patch series for these changes and I will include a new/fixed version of your patch in that series.

/John

> Thanks
> -Gustavo
> 
> [1] https://lore.kernel.org/linux-scsi/20250813200744.17975-10-bgurney@redhat.com/
>