linux-hardening - Re: [PATCH][next] scsi: isci: Avoid -Wflex-array-member-not-at-end warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <729db47f-ac08-4390-a6c2-f0bf01da64c0@embeddedor.com>
Date: Tue, 7 Oct 2025 11:43:42 +0100
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: "Gustavo A. R. Silva" <gustavoars@...nel.org>,
 "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] scsi: isci: Avoid -Wflex-array-member-not-at-end
 warning

Hi all,

Friendly ping: who can take this, please?

Thanks!
-Gustavo

On 9/19/25 12:24, Gustavo A. R. Silva wrote:
> -Wflex-array-member-not-at-end was introduced in GCC-14, and we are
> getting ready to enable it, globally.
> 
> Move the conflicting declaration (which happens to be in a union,
> so we're moving the entire union) to the end of the corresponding
> structure. Notice that `struct ssp_response_iu` is a flexible
> structure, this is a structure that contains a flexible-array member.
> 
> With these changes fix the following warning:
> 
> drivers/scsi/isci/task.h:92:11: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
> 
> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> ---
>   drivers/scsi/isci/task.h | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/isci/task.h b/drivers/scsi/isci/task.h
> index f96633fa6939..d05d09c1263d 100644
> --- a/drivers/scsi/isci/task.h
> +++ b/drivers/scsi/isci/task.h
> @@ -85,15 +85,17 @@ struct isci_tmf {
>   
>   	struct completion *complete;
>   	enum sas_protocol proto;
> +	unsigned char lun[8];
> +	u16 io_tag;
> +	enum isci_tmf_function_codes tmf_code;
> +	int status;
> +
> +	/* Must be last --ends in a flexible-array member. */
>   	union {
>   		struct ssp_response_iu resp_iu;
>   		struct dev_to_host_fis d2h_fis;
>   		u8 rsp_buf[SSP_RESP_IU_MAX_SIZE];
>   	} resp;
> -	unsigned char lun[8];
> -	u16 io_tag;
> -	enum isci_tmf_function_codes tmf_code;
> -	int status;
>   };
>   
>   static inline void isci_print_tmf(struct isci_host *ihost, struct isci_tmf *tmf)