lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <50a789ce-bc76-451b-81e4-2286683f6a17@kernel.org>
Date: Wed, 8 Oct 2025 08:24:37 +0200
From: Hans Verkuil <hverkuil+cisco@...nel.org>
To: Kees Cook <kees@...nel.org>, Luis Chamberlain <mcgrof@...nel.org>
Cc: Hans Verkuil <hverkuil@...nel.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 linux-media@...r.kernel.org, Malcolm Priestley <tvboxspy@...il.com>,
 Rusty Russell <rusty@...tcorp.com.au>, Petr Pavlu <petr.pavlu@...e.com>,
 Daniel Gomez <da.gomez@...nel.org>, Sami Tolvanen <samitolvanen@...gle.com>,
 linux-kernel@...r.kernel.org, linux-modules@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH 2/3] media: radio: si470x: Fix DRIVER_AUTHOR macro
 definition

On 08/10/2025 05:59, Kees Cook wrote:
> The DRIVER_AUTHOR macro incorrectly included a semicolon in its
> string literal definition. Right now, this wasn't causing any real
> problem, but coming changes to the MODULE_INFO() macro make this more
> sensitive. Specifically, when used with MODULE_AUTHOR(), this created
> syntax errors during macro expansion:
> 
>     MODULE_AUTHOR(DRIVER_AUTHOR);
> 
> expands to:
> 
>     MODULE_INFO(author, "Joonyoung Shim <jy0922.shim@...sung.com>";)
>                                                                   ^
>                                                        syntax error
> 
> Remove the trailing semicolon from the DRIVER_AUTHOR definition.
> Semicolons should only appear at the point of use, not in the macro
> definition.
> 
> Signed-off-by: Kees Cook <kees@...nel.org>

Reviewed-by: Hans Verkuil <hverkuil+cisco@...nel.org>

> ---
> Cc: Hans Verkuil <hverkuil@...nel.org>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Cc: <linux-media@...r.kernel.org>
> ---
>  drivers/media/radio/si470x/radio-si470x-i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/radio/si470x/radio-si470x-i2c.c b/drivers/media/radio/si470x/radio-si470x-i2c.c
> index cdd2ac198f2c..3932a449a1b1 100644
> --- a/drivers/media/radio/si470x/radio-si470x-i2c.c
> +++ b/drivers/media/radio/si470x/radio-si470x-i2c.c
> @@ -10,7 +10,7 @@
>  
>  
>  /* driver definitions */
> -#define DRIVER_AUTHOR "Joonyoung Shim <jy0922.shim@...sung.com>";
> +#define DRIVER_AUTHOR "Joonyoung Shim <jy0922.shim@...sung.com>"
>  #define DRIVER_CARD "Silicon Labs Si470x FM Radio"
>  #define DRIVER_DESC "I2C radio driver for Si470x FM Radio Receivers"
>  #define DRIVER_VERSION "1.0.2"


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ