linux-hardening - Re: [PATCH] arc: Add const attribute support for mathematical ARC builtins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202510072026.568651EE@keescook>
Date: Tue, 7 Oct 2025 20:29:01 -0700
From: Kees Cook <kees@...nel.org>
To: Qing Zhao <qing.zhao@...cle.com>
Cc: Claudiu Zissulescu <claziss@...il.com>,
	"gcc-patches@....gnu.org" <gcc-patches@....gnu.org>,
	"linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>
Subject: Re: [PATCH] arc: Add const attribute support for mathematical ARC
 builtins

On Tue, Oct 07, 2025 at 09:02:21PM +0000, Qing Zhao wrote:
> Hi, Kees,
> 
> I took a look at the patch today. 
> Overall, I think the patch is good and should work well. 

Thanks!

> My major questions are:
> 
> 1. Are the five functions in the current list the only functions in __builtin_arc_*** that 
> have const attribute?  

They are the only ones I can safely assert are const attribute without
doing additional work. I'm sure there are more, but I didn't feel
comfortable marking others.

> 2. In addition to “const” attribute, are there any other important attributes should be added for
> the arc builtins to enable more optimizations?

Again, I'm not sure. But my goal here is to make it possible to add
these going forward if people find stuff to add. Before this patch it
wasn't possible at all -- the infrastructure to do so was missing, so
that's what I wanted to add: the infrastructure and the first user. :)

-- 
Kees Cook