linux-hardening - Re: [PATCH v3 01/10] string: provide strends()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQIws1zwi96r4bUQ@smile.fi.intel.com>
Date: Wed, 29 Oct 2025 17:20:19 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Kees Cook <kees@...nel.org>, Mika Westerberg <westeri@...nel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Manivannan Sadhasivam <mani@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Saravana Kannan <saravanak@...gle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andy Shevchenko <andy@...nel.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>,
	Srinivas Kandagatla <srini@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Alexey Klimov <alexey.klimov@...aro.org>,
	linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-sound@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v3 01/10] string: provide strends()

On Wed, Oct 29, 2025 at 01:36:55PM +0100, Bartosz Golaszewski wrote:
> On Wed, Oct 29, 2025 at 12:42 PM Andy Shevchenko
> <andriy.shevchenko@...el.com> wrote:
> > On Wed, Oct 29, 2025 at 12:20:37PM +0100, Bartosz Golaszewski wrote:

...

> > Can you rather re-use strcmp_suffix() from drivers/of/property.c?
> 
> I think that strends() and its boolean return value are a bit more
> intuitive to use than strcmp_suffix() and its integer return value,
> the meaning of which you typically have to look-up to figure out. If
> there are no objections, I'd like to keep it and - when it's upstream
> - convert property.c to using it instead. Also: the name
> strcmp_suffix() could use some improvement, seeing how I wasn't able
> to find it, even though I looked hard across the kernel source, while
> I easily stumbled upon a similar implementation of strends() already
> existing in dtc sources.

I fine as long as the replacement (deduplication) change is provided.

-- 
With Best Regards,
Andy Shevchenko