linux-hardening - Re: [PATCH v3 10/10] regulator: make the subsystem aware of shared GPIOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQIw97qdO43NXHWi@smile.fi.intel.com>
Date: Wed, 29 Oct 2025 17:21:27 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Kees Cook <kees@...nel.org>, Mika Westerberg <westeri@...nel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Manivannan Sadhasivam <mani@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Saravana Kannan <saravanak@...gle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andy Shevchenko <andy@...nel.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>,
	Srinivas Kandagatla <srini@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Alexey Klimov <alexey.klimov@...aro.org>,
	linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-sound@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v3 10/10] regulator: make the subsystem aware of shared
 GPIOs

On Wed, Oct 29, 2025 at 01:41:10PM +0100, Bartosz Golaszewski wrote:
> On Wed, Oct 29, 2025 at 12:54 PM Andy Shevchenko
> <andriy.shevchenko@...el.com> wrote:
> > On Wed, Oct 29, 2025 at 12:20:46PM +0100, Bartosz Golaszewski wrote:
> > >
> > > GPIOLIB is now aware of shared GPIOs and - for platforms where access to
> > > such pins is managed internally - we don't need to keep track of the
> > > enable count.
> > >
> > > Once all users in the kernel switch to using the new mechanism, we'll be
> > > able to drop the internal counting of users from the regulator code.
> >
> > I am wondering if you took into account the layering violation (or others
> > put it as "transferring of ownership") in the regulator core for the platform
> > based GPIO regulators? This popped up during the discussion of
> > https://lore.kernel.org/platform-driver-x86/20251024050537.92440-1-qiuwenbo@gnome.org/
> 
> I am aware of this weird ownership transfer in regulator but these
> changes don't affect it. The layering is still being violated though.
> 
> This should be fixed and I've looked into it but it's not trivial so
> it's another big rework for the future.

OK, thanks for clarifications!

-- 
With Best Regards,
Andy Shevchenko