linux-hardening - Re: [PATCH v2 0/3] module: Add compile-time check for embedded NUL characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab56339a-8736-4d68-bf11-d27c8d591597@kernel.org>
Date: Tue, 4 Nov 2025 07:35:19 +0100
From: Daniel Gomez <da.gomez@...nel.org>
To: Kees Cook <kees@...nel.org>, Hans Verkuil <hverkuil+cisco@...nel.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: Luis Chamberlain <mcgrof@...nel.org>,
 Malcolm Priestley <tvboxspy@...il.com>, Hans Verkuil <hverkuil@...nel.org>,
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 Rusty Russell <rusty@...tcorp.com.au>, Petr Pavlu <petr.pavlu@...e.com>,
 Sami Tolvanen <samitolvanen@...gle.com>, linux-kernel@...r.kernel.org,
 linux-media@...r.kernel.org, linux-modules@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2 0/3] module: Add compile-time check for embedded NUL
 characters



On 04/11/2025 01.13, Kees Cook wrote:
> On Mon, Nov 03, 2025 at 08:49:43PM +0100, Daniel Gomez wrote:
>>
>> On Thu, 09 Oct 2025 20:06:06 -0700, Kees Cook wrote:
>>>  v2:
>>>  - use static_assert instead of _Static_assert
>>>  - add Hans's Reviewed-by's
>>>  v1: https://lore.kernel.org/lkml/20251008033844.work.801-kees@kernel.org/
>>>
>>> Hi!
>>>
>>> [...]
>>
>> Applied patch 3, thanks!
>>
>> [3/3] module: Add compile-time check for embedded NUL characters
>>       commit: 913359754ea821c4d6f6a77e0449b29984099663
> 
> I'm nervous about this going in alone -- it breaks allmodconfig builds
> without the media fixes. My intention was to have the media fixes land
> first...
> 
> Should I send the media fixes to linus right away?
> 
> -Kees
> 

I can take both patches. But I think it'd make sense to drop patch 3 first and
then, apply all 3.

Please, Kees, Hans and Mauro, let me know if this is okay with you.