linux-hardening - Re: [PATCH v2 2/3] arm64: dts: qcom: sm8150: Move usb-role-switch property to common dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aab04ca7-999c-4143-bdc0-e947d46e1424@ixit.cz>
Date: Tue, 4 Nov 2025 23:32:31 +0100
From: David Heidelberg <david@...t.cz>
To: Piyush Raj Chouhan <pc1598@...nlining.org>, linux-arm-msm@...r.kernel.org
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org, andersson@...nel.org,
 konradybcio@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, tony.luck@...el.com, gpiccoli@...lia.com
Subject: Re: [PATCH v2 2/3] arm64: dts: qcom: sm8150: Move usb-role-switch
 property to common dtsi

You have to provide the commit message, even when the change seems to 
you self-explaining. Just one or two sentences explaining why.

David

On 04/11/2025 23:16, Piyush Raj Chouhan wrote:
> Signed-off-by: Piyush Raj Chouhan <pc1598@...nlining.org>
> ---
>   arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 1 -
>   arch/arm64/boot/dts/qcom/sm8150.dtsi    | 2 ++
>   2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8150-hdk.dts b/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
> index 0339a572f34d..29afee6160cd 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
> @@ -693,7 +693,6 @@ &usb_2 {
>   
>   &usb_1_dwc3 {
>   	dr_mode = "otg";
> -	usb-role-switch;
>   };
>   
>   &usb_1_dwc3_hs {
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index acdba79612aa..cd05975dacd1 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -3661,6 +3661,8 @@ usb_1_dwc3: usb@...0000 {
>   				phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>;
>   				phy-names = "usb2-phy", "usb3-phy";
>   
> +				usb-role-switch;
> +
>   				ports {
>   					#address-cells = <1>;
>   					#size-cells = <0>;

-- 
David Heidelberg