linux-hardening - Re: linux-next-20251029

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGG=3QUF4OZwjjMTz8jidDWNiHrOhhZhKNRwM54gz8YLHeRGBw@mail.gmail.com>
Date: Thu, 6 Nov 2025 15:49:50 -0800
From: Bill Wendling <morbo@...gle.com>
To: Kees Cook <kees@...nel.org>
Cc: Valdis Klētnieks <valdis.kletnieks@...edu>, 
	Amit Dhingra <mechanicalamit@...il.com>, Timur Kristóf <timur.kristof@...il.com>, 
	Alex Deucher <alexander.deucher@....com>, Leo Li <sunpeng.li@....com>, 
	David Airlie <airlied@...il.com>, amd-gfx list <amd-gfx@...ts.freedesktop.org>, 
	dri-devel <dri-devel@...ts.freedesktop.org>, linux-kernel@...r.kernel.org, 
	linux-hardening@...r.kernel.org
Subject: Re: linux-next-20251029 - build error in amdgpu

On Thu, Nov 6, 2025 at 6:13 AM Kees Cook <kees@...nel.org> wrote:
> On November 5, 2025 7:18:51 PM PST, "Valdis Klētnieks" <valdis.kletnieks@...edu> wrote:
> >On Wed, 05 Nov 2025 18:34:05 -0800, Amit Dhingra said:
> >
> >> I have the same problem.
> >>  ...
> >
> >> Setting RANDSTRUCT_NONE=y seems to stop the error.
> >>
> >> [1] https://lore.kernel.org/all/2025062439-tamer-diner-68e9@gregkh/
> >
> >Wow.  I wouldn't have guessed that RANDSTRUCT would be the cause...
> >However, RANDSTRUCT_NONE=y does make dce_stream_encoder.c compile cleanly.
> >
> ><insert Twilight Zone theme music here>
> >
> >Adding Kees Cook and the linux-hardening list to the cc:, hope somebody has an
> >idea what's going on.
>
> I'm surprised the stable team didn't find the associated fix in your linked thread. It had the right Fixes tag:
> https://lore.kernel.org/all/20250502224156.work.617-kees@kernel.org/
>
FYI, their Fixes tag points to something that doesn't exist. I found
it at SHA1 e136a4062174a9a8d1c1447ca040ea81accfa6a8 though.

> Regardless, just remove the "0" from the dce110_an_str_enc_funcs initializer; that's an older code pattern that isn't needed any more.
>
> Randstruct requires designated initializers, though I thought the macro turned that on universally, so the fact that the error is only present with randstruct seems like a separate bug.
>
> -Kees
>
> --
> Kees Cook
>