Message-id: <176255458305.634289.5577159882824096330@noble.neil.brown.name>
Date: Sat, 08 Nov 2025 09:29:43 +1100
From: NeilBrown <neilb@...mail.net>
To: "Jeff Layton" <jlayton@...nel.org>
Cc: "Eric Van Hensbergen" <ericvh@...nel.org>,
 "Latchesar Ionkov" <lucho@...kov.net>,
 "Dominique Martinet" <asmadeus@...ewreck.org>,
 "Christian Schoenebeck" <linux_oss@...debyte.com>,
 "David Sterba" <dsterba@...e.com>, "David Howells" <dhowells@...hat.com>,
 "Marc Dionne" <marc.dionne@...istor.com>,
 "Alexander Viro" <viro@...iv.linux.org.uk>,
 "Christian Brauner" <brauner@...nel.org>, "Jan Kara" <jack@...e.cz>,
 "Tigran A. Aivazian" <aivazian.tigran@...il.com>,
 "Chris Mason" <clm@...com>, "Xiubo Li" <xiubli@...hat.com>,
 "Ilya Dryomov" <idryomov@...il.com>, "Jan Harkes" <jaharkes@...cmu.edu>,
 coda@...cmu.edu, "Tyler Hicks" <code@...icks.com>,
 "Jeremy Kerr" <jk@...abs.org>, "Ard Biesheuvel" <ardb@...nel.org>,
 "Namjae Jeon" <linkinjeon@...nel.org>,
 "Sungjong Seo" <sj1557.seo@...sung.com>,
 "Yuezhang Mo" <yuezhang.mo@...y.com>, "Theodore Ts'o" <tytso@....edu>,
 "Andreas Dilger" <adilger.kernel@...ger.ca>,
 "Jaegeuk Kim" <jaegeuk@...nel.org>, "Chao Yu" <chao@...nel.org>,
 "OGAWA Hirofumi" <hirofumi@...l.parknet.co.jp>,
 "Miklos Szeredi" <miklos@...redi.hu>,
 "Andreas Gruenbacher" <agruenba@...hat.com>,
 "Viacheslav Dubeyko" <slava@...eyko.com>,
 "John Paul Adrian Glaubitz" <glaubitz@...sik.fu-berlin.de>,
 "Yangtao Li" <frank.li@...o.com>, "Richard Weinberger" <richard@....at>,
 "Anton Ivanov" <anton.ivanov@...bridgegreys.com>,
 "Johannes Berg" <johannes@...solutions.net>,
 "Mikulas Patocka" <mikulas@...ax.karlin.mff.cuni.cz>,
 "Muchun Song" <muchun.song@...ux.dev>,
 "Oscar Salvador" <osalvador@...e.de>,
 "David Hildenbrand" <david@...hat.com>,
 "David Woodhouse" <dwmw2@...radead.org>,
 "Dave Kleikamp" <shaggy@...nel.org>,
 "Trond Myklebust" <trondmy@...nel.org>,
 "Anna Schumaker" <anna@...nel.org>,
 "Ryusuke Konishi" <konishi.ryusuke@...il.com>,
 "Konstantin Komarov" <almaz.alexandrovich@...agon-software.com>,
 "Mark Fasheh" <mark@...heh.com>, "Joel Becker" <jlbec@...lplan.org>,
 "Joseph Qi" <joseph.qi@...ux.alibaba.com>,
 "Bob Copeland" <me@...copeland.com>,
 "Mike Marshall" <hubcap@...ibond.com>,
 "Martin Brandenburg" <martin@...ibond.com>,
 "Amir Goldstein" <amir73il@...il.com>,
 "Steve French" <sfrench@...ba.org>, "Paulo Alcantara" <pc@...guebit.org>,
 "Ronnie Sahlberg" <ronniesahlberg@...il.com>,
 "Shyam Prasad N" <sprasad@...rosoft.com>, "Tom Talpey" <tom@...pey.com>,
 "Bharath SM" <bharathsm@...rosoft.com>,
 "Zhihao Cheng" <chengzhihao1@...wei.com>,
 "Hans de Goede" <hansg@...nel.org>, "Carlos Maiolino" <cem@...nel.org>,
 "Hugh Dickins" <hughd@...gle.com>,
 "Baolin Wang" <baolin.wang@...ux.alibaba.com>,
 "Andrew Morton" <akpm@...ux-foundation.org>,
 "Kees Cook" <kees@...nel.org>,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>,
 "Jonathan Corbet" <corbet@....net>,
 "Matthew Wilcox (Oracle)" <willy@...radead.org>,
 linux-kernel@...r.kernel.org, v9fs@...ts.linux.dev,
 linux-fsdevel@...r.kernel.org, linux-afs@...ts.infradead.org,
 linux-btrfs@...r.kernel.org, ceph-devel@...r.kernel.org,
 codalist@...a.cs.cmu.edu, ecryptfs@...r.kernel.org,
 linux-efi@...r.kernel.org, linux-ext4@...r.kernel.org,
 linux-f2fs-devel@...ts.sourceforge.net, gfs2@...ts.linux.dev,
 linux-um@...ts.infradead.org, linux-mm@...ck.org,
 linux-mtd@...ts.infradead.org, jfs-discussion@...ts.sourceforge.net,
 linux-nfs@...r.kernel.org, linux-nilfs@...r.kernel.org,
 ntfs3@...ts.linux.dev, ocfs2-devel@...ts.linux.dev,
 linux-karma-devel@...ts.sourceforge.net, devel@...ts.orangefs.org,
 linux-unionfs@...r.kernel.org, linux-cifs@...r.kernel.org,
 samba-technical@...ts.samba.org, linux-xfs@...r.kernel.org,
 linux-hardening@...r.kernel.org, linux-doc@...r.kernel.org,
 "Jeff Layton" <jlayton@...nel.org>
Subject: Re: [PATCH v2] vfs: remove the excl argument from the ->create()
 inode_operation

On Sat, 08 Nov 2025, Jeff Layton wrote:
> With two exceptions, ->create() methods provided by filesystems ignore
> the "excl" flag.  Those exception are NFS and GFS2 which both also
> provide ->atomic_open.
> 
> Since ce8644fcadc5 ("lookup_open(): expand the call of vfs_create()"),
> the "excl" argument to the ->create() inode_operation is always set to
> true in vfs_create(). The ->create() call in lookup_open() sets it
> according to the O_EXCL open flag, but is never called if the filesystem
> provides ->atomic_open().
> 
> The excl flag is therefore always either ignored or true.  Remove it,
> and change NFS and GFS2 to act as if it were always true.
> 
> Signed-off-by: Jeff Layton <jlayton@...nel.org>
> ---
> Note that this is based on top of the dir delegation series [1]. LMK
> if the Documentation/ updates are too wordy.

Patch is very nice.  I don't think the documentation is too wordy.
I think it is good that the two changes to the different files say
essentially the same thing but use different words.  That helps.

Reviewed-by: NeilBrown <neil@...wn.name>

> 
> Full disclosure: I did use Claude code to generate the first
> approximation of this patch, but I had to fix a number of things that it
> missed.  I probably could have given it better prompts. In any case, I'm
> not sure how to properly attribute this (or if I even need to).

My understanding is that if you fully understand (and can defend) the
code change with all its motivations and implications as well as if you
had written it yourself, then you don't need to attribute whatever fancy
text editor or IDE (e.g.  Claude) that you used to help produce the
patch.

Thanks,
NeilBrown

Powered by blists - more mailing lists