linux-hardening - Re: [PATCH][next] RDMA/rxe: Avoid -Wflex-array-member-not-at-end warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f15e334-8902-4d1d-adab-aa9ab8f009d6@linux.dev>
Date: Thu, 18 Dec 2025 20:29:55 -0800
From: Zhu Yanjun <yanjun.zhu@...ux.dev>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
 Leon Romanovsky <leon@...nel.org>
Cc: Jason Gunthorpe <jgg@...dia.com>,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>,
 Zhu Yanjun <zyjzyj2000@...il.com>, linux-rdma@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] RDMA/rxe: Avoid -Wflex-array-member-not-at-end
 warnings


在 2025/12/18 18:51, Gustavo A. R. Silva 写道:
>
>
> On 12/19/25 04:22, Yanjun.Zhu wrote:
>>
>> On 12/18/25 7:56 AM, Leon Romanovsky wrote:
>>> On Sun, Dec 14, 2025 at 09:00:51PM -0800, Zhu Yanjun wrote:
>>>>
>>>> 在 2025/12/5 20:41, Zhu Yanjun 写道:
>>>>>
>>>>> 在 2025/12/4 9:48, yanjun.zhu 写道:
>>>>>> On 12/4/25 5:05 AM, Jason Gunthorpe wrote:
>>>>>>> On Wed, Dec 03, 2025 at 09:08:45PM -0800, Zhu Yanjun wrote:
>>>>>>>>>         unsigned int res_head;
>>>>>>>>>         unsigned int        res_tail;
>>>>>>>>>         struct resp_res        *res;
>>>>>>>>> +
>>>>>>>>> +    /* SRQ only. srq_wqe.dma.sge is a flex array */
>>>>>>>>> +    struct rxe_recv_wqe srq_wqe;
>>>>>>>> drivers/infiniband/sw/rxe/rxe_resp.c: In function get_srq_wqe:
>>>>>>>> drivers/infiniband/sw/rxe/rxe_resp.c:289:41: error: struct
>>>>>>>> rxe_recv_wqe has
>>>>>>>> no member named wqe
>>>>>>>>     289 |         qp->resp.wqe = &qp->resp.srq_wqe.wqe;
>>>>>>>>         |                                         ^
>>>>>>> I didn't try to fix all the typos, you will need to do that.
>>>>>> Exactly. I will fix this problem. This weekend, I will send out an
>>>>>> official commit.
>>>>> Hi, Jason
>>>>>
>>>>> The followings are based on your commits and Leon's commits. And 
>>>>> it can
>>>>> pass the rdma-core tests.
>>>>>
>>>>> I am not sure if this commit is good or not.
>>>> Hi, Jason && Leon
>>>>
>>>> Any update? If this looks good to you, I will send out an official 
>>>> commit
>>>> based on the following commit.
>>> You are RXE maintainer, send the official patch.
>>
>> Will do. I will send it out very soon.
>
> I don't see how this addresses the flex-array in the middle issue that
> originated this discussion.

Could you please explain this in more detail?
Also, if you have a better approach, would you mind sending a new commit 
for discussion?

Thanks a lot.

Yanjun.Zhu

>
> -Gustavo

-- 
Best Regards,
Yanjun.Zhu