linux-hardening - Re: [PATCH v3 1/2] lib: introduce simple error-checking wrapper for memparse()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0fb5777b167803debb2c6b77f41e82967fba3b7.camel@yandex.ru>
Date: Fri, 09 Jan 2026 14:41:55 +0300
From: Dmitry Antipov <dmantipov@...dex.ru>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Carlos Maiolino <cem@...nel.org>, Christoph Hellwig <hch@...radead.org>,
  Kees Cook <kees@...nel.org>, Andy Shevchenko <andy@...nel.org>, Andrew
 Morton	 <akpm@...ux-foundation.org>, linux-xfs@...r.kernel.org, 
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH v3 1/2] lib: introduce simple error-checking wrapper for
 memparse()

On Thu, 2026-01-08 at 22:05 +0200, Andy Shevchenko wrote:

> 1) inherited one with strange indentation;

Hm...where? AFAICS everything is properly indented with TABs.

> 2) missing Return section (run kernel-doc validator with -Wreturn,
> for example).

Good point. Should checkpatch.pl call kernel-doc (always or perhaps
if requested using command-line option)?

OTOH 1) lib/cmdline.c violates kernel-doc -Wreturn almost everywhere
:-( and 2) IIUC this patch is already queued by Andrew. I would
prefer to fix kernel-doc glitches immediately after memvalue() and
its first real use case (presumably XFS) both reaches an upstream.

Dmitry