linux-hardening - Re: [PATCH v3 1/2] lib: introduce simple error-checking wrapper for memparse()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20260110160114.3a1976a90c13a2c79c16e611@linux-foundation.org>
Date: Sat, 10 Jan 2026 16:01:14 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Dmitry Antipov <dmantipov@...dex.ru>, Carlos Maiolino <cem@...nel.org>,
 Christoph Hellwig <hch@...radead.org>, Kees Cook <kees@...nel.org>, Andy
 Shevchenko <andy@...nel.org>, linux-xfs@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH v3 1/2] lib: introduce simple error-checking wrapper for
 memparse()

On Fri, 9 Jan 2026 19:11:31 +0200 Andy Shevchenko <andriy.shevchenko@...el.com> wrote:

> On Fri, Jan 09, 2026 at 02:41:55PM +0300, Dmitry Antipov wrote:
> > On Thu, 2026-01-08 at 22:05 +0200, Andy Shevchenko wrote:
> 
> ...
> 
> > > 2) missing Return section (run kernel-doc validator with -Wreturn,
> > > for example).
> > 
> > Good point. Should checkpatch.pl call kernel-doc (always or perhaps
> > if requested using command-line option)?
> > 
> > OTOH 1) lib/cmdline.c violates kernel-doc -Wreturn almost everywhere
> > :-( and 2) IIUC this patch is already queued by Andrew.
> 
> Andrew's workflow allows folding / squashing patches.

And replacing and dropping and reordering...

Please, just do whatever you feel most appropriate.  I'll cope ;)