linux-hardening - Re: [PATCH 6/6] arm64: dts: qcom: Add Redmi Note 8T

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4cb609391559a88a4a6f1e2f550f8450@mainlining.org>
Date: Fri, 16 Jan 2026 07:53:45 +0100
From: barnabas.czeman@...nlining.org
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio
 <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Gabriel Gonzales
 <semfault@...root.org>, Kees Cook <kees@...nel.org>, Tony Luck
 <tony.luck@...el.com>, "Guilherme G. Piccoli" <gpiccoli@...lia.com>,
 Biswapriyo Nath <nathbappai@...il.com>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org, phone-devel@...r.kernel.org,
 ~postmarketos/upstreaming@...ts.sr.ht, linux@...nlining.org
Subject: Re: [PATCH 6/6] arm64: dts: qcom: Add Redmi Note 8T

On 2026-01-13 10:04, Konrad Dybcio wrote:
> On 1/12/26 9:13 PM, Barnabás Czémán wrote:
>> Redmi Note 8T (willow) is very similar to Redmi Note 8 (ginkgo)
>> the only difference is willow have NFC.
>> Make a common base from ginkgo devicetree for both device.
>> 
>> Signed-off-by: Barnabás Czémán <barnabas.czeman@...nlining.org>
>> ---
> 
> [...]
> 
>> diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts 
>> b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
>> index 163ecdc7fd6c..70be19357d11 100644
>> --- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
>> @@ -1,304 +1,12 @@
>>  // SPDX-License-Identifier: BSD-3-Clause
>>  /*
>> - * Copyright (c) 2025, Gabriel Gonzales <semfault@...root.org>
>> + * Copyright (c) 2026, Barnabas Czeman
> 
> Is there a reason for you to remove Gabriel's copyright from the 5 LoC
> that remain in this file?
The original file was renamed to sm6125-xiaomi-ginkgo-common.dtsi.
I have not removed it, it is a new file with the old file name but
i can add Gabriel's copyright here also, would that be fine?

> 
> Adding your own to an existing file in a commit that mostly moves code
> around is also odd. It would look considerably better if you did so in
> one of the previous commits that fixed things, as those contributions
> are easier to perceive as non-trivial.
> 
> Konrad