linux-hardening - Re: [PATCH] [RFC PATCH] lib/string: fix coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026021409-clothes-subarctic-3dd2@gregkh>
Date: Sat, 14 Feb 2026 15:02:46 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Samyak <samyak.bambole07@...il.com>
Cc: akpm@...ux-foundation.org, kees@...nel.org, andy@...nel.org,
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] [RFC PATCH] lib/string: fix coding style issues

On Sat, Feb 14, 2026 at 07:21:07PM +0530, Samyak wrote:
> - Add spaces around binary operators
> - remove spaces after casts
> - Add blank line after variable declarations
> - Fix constant on left side of a conditional expression (0 < count ->
>   count > 0)
> - Remove un-needed braces around single statements
> 
> Signed-off-by: Samyak Bambole <samyak.bambole07@...il.com>
> ---
> This is my first linux kernel patch. I have compiled and tested the
> changes on QEMU. I would appreciate any feedback. Thanks.
> 
>  lib/string.c | 27 ++++++++++++++++-----------

If you want to get involved in kernel work, please do coding style
changes in drivers/staging/ which is there to learn on how to do this.
Only after doing this a lot, and getting experience, should you venture
out of drivers/staging/

Also, many subsystems do not want coding style fixes for obvious reasons
(i.e. they change over time and keeping the whole codebase up to date
like this would be constant churn.)

Hint, this patch would need to be broken up anyway, you should only do
"one logical thing" per patch.  And "fix all coding style issues" is not
one thing :)

thanks,

greg k-h