linux-hardening - Re: [PATCH 3/3] module: Add compile-time check for embedded NUL characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACePvbVCwr2hc+gqUBWz++GKsk6+c97sBrVRFJ015jyeLkDbcw@mail.gmail.com>
Date: Thu, 19 Feb 2026 09:04:29 -0800
From: Chris Li <sparse@...isli.org>
To: "Luck, Tony" <tony.luck@...el.com>
Cc: Dan Carpenter <dan.carpenter@...aro.org>, Al Viro <viro@...iv.linux.org.uk>, 
	Daniel Gomez <da.gomez@...nel.org>, Sami Tolvanen <samitolvanen@...gle.com>, 
	Eric Biggers <ebiggers@...nel.org>, Kees Cook <kees@...nel.org>, 
	Luis Chamberlain <mcgrof@...nel.org>, Rusty Russell <rusty@...tcorp.com.au>, 
	Petr Pavlu <petr.pavlu@...e.com>, 
	"linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>, Malcolm Priestley <tvboxspy@...il.com>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Hans Verkuil <hverkuil@...nel.org>, 
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>, 
	"linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>
Subject: Re: [PATCH 3/3] module: Add compile-time check for embedded NUL characters

Hi Tony,

Sorry for the late reply.

On Fri, Dec 19, 2025 at 8:21 AM Luck, Tony <tony.luck@...el.com> wrote:
>
> On Fri, Dec 19, 2025 at 03:45:42PM +0300, Dan Carpenter wrote:
> > On Fri, Dec 12, 2025 at 02:30:48AM +0900, Daniel Gomez wrote:
> > > Maybe the flag fix just needs to be applied to the evaluation? Other op
> > > structs do the same. But Dan's patch did not implement evaluate. E.g.:
> > >
> > > static struct symbol_op constant_p_op = {
> > >     .evaluate = evaluate_to_int_const_expr,
> > >     .expand = expand_constant_p
> > > };
> > >
> >
> > I was waiting for you to send this as a patch.  I can do it if you
> > need me to.
>
> Dan,
>
> Al Viro thought this was wrong. His alternative patch is here:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/viro/sparse.git/commit/?id=2634e39bf02697a18fece057208150362c985992

Hi Al, should I pull from your git repo
https://git.kernel.org/pub/scm/linux/kernel/git/viro/sparse.git/
instead? I saw there is more than one commit. I assume it is ready to
pull. Please let me know if I shouldn't.

Thanks

Chris