linux-kernel - Re: [RFC][PATCH 4/6] slim: secfs patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1152898983.314.9.camel@localhost.localdomain>
Date:	Fri, 14 Jul 2006 10:43:03 -0700
From:	Dave Hansen <haveblue@...ibm.com>
To:	Kylene Jo Hall <kjhall@...ibm.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	LSM ML <linux-security-module@...r.kernel.org>,
	Dave Safford <safford@...ibm.com>,
	Mimi Zohar <zohar@...ibm.com>, Serge Hallyn <sergeh@...ibm.com>
Subject: Re: [RFC][PATCH 4/6] slim: secfs patch

On Fri, 2006-07-14 at 10:24 -0700, Kylene Jo Hall wrote:
> 
> +static ssize_t slm_read_level(struct file *file, char __user *buf,
> +                             size_t buflen, loff_t *ppos)
> +{
> +       struct slm_tsec_data *cur_tsec = current->security;
> +       ssize_t len;
> +       char *page = (char *)__get_free_page(GFP_KERNEL); 

Do you really need a page here?  Why not just use kmalloc()?

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/