linux-kernel - Re: [PATCH] reiserfs: fix handling of device names with /'s in them

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1G1QFx-0001IO-K6@be1.lrz>
Date:	Fri, 14 Jul 2006 18:10:49 +0200
From:	Bodo Eggert <7eggert@...tempel.de>
To:	Eric Dumazet <dada1@...mosbay.com>, Jeff Mahoney <jeffm@...e.com>,
	ReiserFS List <reiserfs-list@...esys.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] reiserfs: fix handling of device names with /'s in them

Eric Dumazet <dada1@...mosbay.com> wrote:
> On Wednesday 12 July 2006 18:42, Jeff Mahoney wrote:

>>  On systems with block devices containing slashes (virtual dasd, cciss,
>>  etc), reiserfs will fail to initialize /proc/fs/reiserfs/<dev> due to
>>  it being interpreted as a subdirectory. The generic block device code
>>  changes the / to ! for use in the sysfs tree. This patch uses that
>>  convention.
>>
>>  Tested by making dm devices use dm/<number> rather than dm-<number>
> 
> Your patch handles at most one slash. But the description mentions 'slashes'
> (ie several slashes)

Besides that, there is no reason to prevent the user from using many slashes.
OTOH, I'd prefer propper quoting, but having each driver do this would be
insane.

> Maybe you need a loop
> 
> while (s) {
[...]

s = bdev;
while (s = strchr(s, '/'))
        *s = '!';
-- 
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF
verbreiteten Lügen zu sabotieren.

http://david.woodhou.se/why-not-spf.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/