linux-kernel - Re: [PATCH] Add SATA device to VIA IRQ quirk fixup list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20060714212153.9196b4cb.vsu@altlinux.ru>
Date:	Fri, 14 Jul 2006 21:21:53 +0400
From:	Sergey Vlasov <vsu@...linux.ru>
To:	Daniel Drake <dsd@...too.org>
Cc:	Sergio Monteiro Basto <sergio@...giomb.no-ip.org>,
	Chris Wedgwood <cw@...f.org>, Andrew Morton <akpm@...l.org>,
	Jeff Garzik <jeff@...zik.org>, greg@...ah.com, harmon@....edu,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add SATA device to VIA IRQ quirk fixup list

On Fri, 14 Jul 2006 18:06:08 +0100 Daniel Drake wrote:

> Sergio Monteiro Basto wrote:
> >> I just confirmed this on my own system, at least partially. I removed 
> >> the quirk and the system booted fine.
> >>
> >> This is with ACPI enabled, but APIC not enabled (hence the interrupts 
> >> are XT-PIC). I cannot enable APIC on this system due to buggy BIOS.
> >>
> >> Daniel
> > 
> > Daniel, VIA_SATA is not in the list , so when you write remove , you
> > remove what ? or you want say the opposite ?  
> > Please rephrase your sentence .
> 
> Sorry, I should have been clearer. I do not own any VIA SATA hardware 
> (that info was relayed from a Gentoo bug report). My own hardware is 
> older, [Apollo KT266/A/333]. The quirk gets applied to my IDE controller 
> only (both before and after Chris's changes), and I boot from a disk 
> connected to this IDE controller.

Then the quirk effectively does nothing - the IDE controller is most
likely in legacy mode, and therefore does not use its PCI interrupt (it
uses legacy IRQs 15 and 14 instead).

> 00:00.0 Host bridge: VIA Technologies, Inc. VT8366/A/7 [Apollo KT266/A/333]
> 00:01.0 PCI bridge: VIA Technologies, Inc. VT8366/A/7 [Apollo 
> KT266/A/333 AGP]
> 00:09.0 Ethernet controller: Realtek Semiconductor Co., Ltd. 
> RTL-8139/8139C/8139C+ (rev 10)
> 00:0b.0 Ethernet controller: Realtek Semiconductor Co., Ltd. 
> RTL-8139/8139C/8139C+ (rev 10)
> 00:11.0 ISA bridge: VIA Technologies, Inc. VT8233A ISA Bridge
> 00:11.1 IDE interface: VIA Technologies, Inc. 
> VT82C586A/B/VT82C686/A/B/VT823x/A/C PIPC Bus Master IDE (rev 06)
> 00:11.2 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1 
> Controller (rev 23)
> 00:11.3 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1 
> Controller (rev 23)

On this system the quirk would matter only for these USB controllers.

> 01:00.0 VGA compatible controller: nVidia Corporation NV15 [GeForce2 
> GTS/Pro] (rev a3)
> 
> When I said I removed the quirk, I meant I removed the whole quirk, 
> which prevented it from running on my hardware.
> 
> > Do you need quirk SATA with acpi=off  ?
> 
> Assuming you mean "quirk IDE", no.
> 
> > Do you need quirk with ACPI enabled ? 
> 
> No. But, my interrupts are always XT-PIC, I cannot enable IO-APIC (not 
> sure how much relevance that has, possibly worth noting though).

When IO-APIC is used, the "& 0x0f" part of the quirk becomes relevant -
in this mode 0 in the register means IO-APIC IRQ 16, 1 means IRQ 17,
etc...  However, not all chips work like this - e.g., the builtin audio
device of VT8237 has fixed IRQ routing in IO-APIC mode and ignores the
value of PCI_INTERRUPT_LINE completely.

Content of type "application/pgp-signature" skipped