linux-kernel - Re: functions returning 0 on success [was: [PATCH] Fix a memory leak in the i386 setup code]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200607151333.16817.dtor@insightbb.com>
Date:	Sat, 15 Jul 2006 13:33:16 -0400
From:	Dmitry Torokhov <dtor@...ightbb.com>
To:	Michael Tokarev <mjt@....msk.ru>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: functions returning 0 on success [was: [PATCH] Fix a memory leak in the i386 setup code]

On Monday 10 July 2006 18:45, Michael Tokarev wrote:
> In such cases when a routine returns 0 on error, I usually write
> it this way:
> 
>    if (request_resource() != 0)
>      fail()
> 


Many write:

	error = do_something();
	if (error) {
		...
	}

And then it really obvious.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/