linux-kernel - Re: [RFC: -mm patch] drivers/char/scx200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <44B97EF6.50202@gmail.com>
Date:	Sat, 15 Jul 2006 17:49:10 -0600
From:	Jim Cromie <jim.cromie@...il.com>
To:	Adrian Bunk <bunk@...sta.de>
CC:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [RFC: -mm patch] drivers/char/scx200_gpio.c: make code static

Adrian Bunk wrote:
> This patch makes needlessly global code static.
>
> Signed-off-by: Adrian Bunk <bunk@...sta.de>
>
>   
Nak on 1st 2 chunks - exported vtable is now used, an should (hopefully)
serve as a universal gpio interface.
Here it is again, with the 2 chunks stripped.

---

This patch makes a needlessly global variable static.

Signed-off-by: Adrian Bunk <bunk@...sta.de>
Signed-off-by: Jim Cromie  <jim.cromie@...il.com>
---

$ diffstat fxd1/scx200_gpio.c-make-code-static.eml
 scx200_gpio.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)


--- linux-2.6.18-rc1-mm2-full/drivers/char/scx200_gpio.c.old	2006-07-14 22:31:22.000000000 +0200
+++ linux-2.6.18-rc1-mm2-full/drivers/char/scx200_gpio.c	2006-07-14 22:31:44.000000000 +0200
@@ -69,7 +68,7 @@
 	.release = scx200_gpio_release,
 };
 
-struct cdev scx200_gpio_cdev;  /* use 1 cdev for all pins */
+static struct cdev scx200_gpio_cdev;  /* use 1 cdev for all pins */
 
 static int __init scx200_gpio_init(void)
 {




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/