linux-kernel - Re: 2.6.18-rc1-mm2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20060714.224001.71089810.davem@davemloft.net>
Date:	Fri, 14 Jul 2006 22:40:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: 2.6.18-rc1-mm2

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Sat, 15 Jul 2006 11:06:45 +1000

> -	__ret;						\
> +	unlikely(__ret);				\

Wouldn't it be cleaner to wrap this unlikely around
the top-level "({ })"?  When it sits on a line by
itself it looks strange, that much is true :)

Actually, the last time I saw a construct like this
it was a bug, someone was doing:

	return unlikely(someval);

which turned someval into a boolean, even though what
was intended was that the full value was returned.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/