linux-kernel - Re: [linux-usb-devel] [RFC: -mm patch] drivers/usb/core/driver.c: make 2 functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 15 Jul 2006 08:50:01 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Adrian Bunk <bunk@...sta.de>
cc:	Andrew Morton <akpm@...l.org>, <gregkh@...e.de>,
	<linux-kernel@...r.kernel.org>,
	<linux-usb-devel@...ts.sourceforge.net>
Subject: Re: [linux-usb-devel] [RFC: -mm patch] drivers/usb/core/driver.c:
 make 2 functions static

On Sat, 15 Jul 2006, Adrian Bunk wrote:

> This patch makes two needlessly global functions static.
> 
> Signed-off-by: Adrian Bunk <bunk@...sta.de>
...
> --- linux-2.6.18-rc1-mm2-full/drivers/usb/core/driver.c.old	2006-07-14 23:29:20.000000000 +0200
> +++ linux-2.6.18-rc1-mm2-full/drivers/usb/core/driver.c	2006-07-14 23:29:51.000000000 +0200
> @@ -471,7 +471,7 @@
>  }
>  EXPORT_SYMBOL_GPL_FUTURE(usb_match_id);
>  
> -int usb_device_match(struct device *dev, struct device_driver *drv)
> +static int usb_device_match(struct device *dev, struct device_driver *drv)
>  {
>  	/* devices and interfaces are handled separately */
>  	if (is_usb_device(dev)) {
> @@ -877,7 +877,7 @@
>  }
>  
>  /* Caller has locked udev */
> -int usb_suspend_both(struct usb_device *udev, pm_message_t msg)
> +static int usb_suspend_both(struct usb_device *udev, pm_message_t msg)
>  {
>  	int			status = 0;
>  	int			i = 0;

There's no problem with making usb_device_match() static, but I've got a
patch almost ready for submission which needs usb_suspend_both() to be
publicly visible.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/