linux-kernel - Re: [PATCH] reiserfs: fix handling of device names with /'s in them

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 16 Jul 2006 18:17:56 -0400
From:	Jeff Mahoney <jeffm@...e.com>
To:	Hans Reiser <reiser@...esys.com>
Cc:	7eggert@....de, Eric Dumazet <dada1@...mosbay.com>,
	ReiserFS List <reiserfs-list@...esys.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] reiserfs: fix handling of device names with /'s in them

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hans Reiser wrote:
> This sounds like it should be fixed in the driver, not in reiserfs.  It
> sounds like the driver is violating Posix naming, and should be fixed to
> conform to it.  Have the driver create an fs mountpoint, and then have
> the driver handle the number.  I really don't get why reiserfs has any
> role in this problem.  Regarding "a separate name space that doesn't
> follow the same rules
> as the standard file system name space.", linux does not need those to
> be created, but what I don't understand is exactly in what respect the
> driver namespace does not conform.  It has components separated by
> slashes.  Is this related to the difference between BSD's namei and
> Linux's?  BSD is the one getting it right.....

Hans, we're all in agreement that we'd prefer drivers not use names with
slashes in them, and it would be nice to correct drivers currently using
them. The problem is that when you change the name of a device, that's a
userspace visible change. Scripts that currently expect, say,
/proc/partitions to contain cciss/<number> will break between kernel
versions. Sysfs wants to use the device name as a pathname component,
and as such translates the / to a !, the same as this patch proposes.

Reiserfs gets involved because it expects that name to be usable as a
file system pathname component when it is not intended to be one without
 translating slashes into another character. The difference is that
block device names are allowed to have slashes in them, while normal
file system names are not. The fact is that device driver names, when in
/dev can use separate components, like /dev/cciss/0, but when used in
the manner reiserfs wants them to be used, they can't. Also, I'm not
talking about name spaces like struct namespace, I mean that the group
of names that block device drivers use have different constraints than
the group of names that are allowable as file names.

The fact is that this change is required for users deploying devices
that use slashes in their names to see the proc data for a reiserfs file
system. You can point the finger all you want at the block drivers in
the mean time, but it's still a reiserfs problem.

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFEursULPWxlyuTD7IRAuaoAJ4w9PiYbgSpFzhQraJklOTkSGin7gCfW5I7
bJblQKd/y40fnckG75UhJ8k=
=hLoM
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/