linux-kernel - Re: [PATCH] nbd: Check magic before doing anything else

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <44BBAD28.6040701@steeleye.com>
Date:	Mon, 17 Jul 2006 11:30:48 -0400
From:	Paul Clements <paul.clements@...eleye.com>
To:	Michal Feix <michal@...x.cz>, akpm@...l.org
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nbd: Check magic before doing anything else

Michal Feix wrote:
> We should check magic sequence in reply packet before trying to find
> request with it's request handle. This also solves the problem with
> "Unexpected reply" message beeing logged, when packet with invalid magic
> is received.

Right. Again, we can't return NULL after pulling the request off the 
queue, so we better do this check first.

Andrew, these two look good to me.

Thanks,
Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/