linux-kernel - Re: [stable] [patch-stable 2.6.16] pdflush: handle resume wakeups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20060717152751.GD4888@kroah.com>
Date:	Mon, 17 Jul 2006 08:27:51 -0700
From:	Greg KH <greg@...ah.com>
To:	Pavel Machek <pavel@....cz>
Cc:	stable@...nel.org, kernel list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>, rml@...ell.com
Subject: Re: [stable] [patch-stable 2.6.16] pdflush: handle resume wakeups

On Sat, Jul 08, 2006 at 05:37:31PM +0200, Pavel Machek wrote:
> 
> 2.6.16 needs this. It was merged into 2.6.18-rc1 in
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d616e09ab33aa4d013a93c9b393efd5cebf78521 .
> 
> pdflush is carefully designed to ensure that all wakeups have some
> corresponding work to do - if a woken-up pdflush thread discovers that
> it hasn't been given any work to do then this is considered an error.
> 
> That all broke when swsusp came along - because a timer-delivered
> wakeup to a frozen pdflush thread will just get lost.  This causes the
> pdflush thread to get lost as well: the writeback timer is supposed to
> be re-armed by pdflush in process context, but pdflush doesn't execute
> the callout which does this.
> 
> Fix that up by ignoring the return value from try_to_freeze(): jsut
> proceed, see if we have any work pending and only go back to sleep if
> that is not the case.

Queued to -stable, thanks.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/