linux-kernel - Re: bttv-driver.c:3964: error: void value not ignored as it ought to be

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <44BBEAB0.3080105@linuxtv.org>
Date:	Mon, 17 Jul 2006 15:53:20 -0400
From:	Michael Krufky <mkrufky@...uxtv.org>
To:	Linux and Kernel Video <video4linux-list@...hat.com>
CC:	Randy Dunlap <rdunlap@...otime.net>, Andrew Morton <akpm@...l.org>,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Axel Thimm <Axel.Thimm@...pms.net>
Subject: Re: bttv-driver.c:3964: error: void value not ignored as it ought
 to be

Axel Thimm wrote:
> latest hg fails on > 2.6.17 due to video_device_create_file being void
> but still being asked for a return value in bttv-driver.c
> 
> linux/drivers/media/video/bt8xx/bttv-driver.c:
> 
>    3963 #if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,17)
>    3964         ret = video_device_create_file(btv->video_dev, &class_device_attr_card);
>    3965         if (ret < 0)
> 
> 
> linux/include/media/v4l2-dev.h:
> 
>     379 static inline void
>     380 video_device_create_file(struct video_device *vfd,
>     381                          struct class_device_attribute *attr)
>     382 {
> 
>   CC [M]  /builddir/video4linux-20060717/v4l/flexcop-dma.o
>   CC [M]  /builddir/video4linux-20060717/v4l/bttv-driver.o
> /builddir/video4linux-20060717/v4l/bttv-driver.c: In function 'bttv_register_video':
> /builddir/video4linux-20060717/v4l/bttv-driver.c:3964: error: void value not ignored as it ought to be
> /builddir/video4linux-20060717/v4l/bttv-driver.c: In function 'bttv_probe':
> /builddir/video4linux-20060717/v4l/bttv-driver.c:4074: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'resource_size_t'
> /builddir/video4linux-20060717/v4l/bttv-driver.c:4086: warning: format '%lx' expects type 'long unsigned int', but argument 4 has type 'resource_size_t'
> make[3]: *** [/builddir/video4linux-20060717/v4l/bttv-driver.o] Error 1

Hmmm... This was caused by the "Check all __must_check warnings in
bttv." patch from Randy Dunlap (cc's from original thread added)

I am aware that this was done for various reasons of sanity checking,
however, we cannot check the return value of a void ;-)

-Mike
-- 
Michael Krufky

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/