linux-kernel - Re: [Fwd: Re: [PATCH] tpm: interrupt clear fix]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060717210425.GA16076@kroah.com>
Date:	Mon, 17 Jul 2006 14:04:25 -0700
From:	Greg KH <greg@...ah.com>
To:	Kylene Jo Hall <kjhall@...ibm.com>
Cc:	stable@...nel.org, Greg KH <gregkh@...e.de>, torvalds@...l.org,
	akpm@...l.org, "Theodore Ts'o" <tytso@....edu>,
	Zwane Mwaikambo <zwane@....linux.org.uk>,
	Justin Forbes <jmforbes@...uxtx.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Chris Wedgwood <reviews@...cw.f00f.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Dave Jones <davej@...hat.com>,
	Chuck Wolber <chuckw@...ntumlinux.com>,
	alan@...rguk.ukuu.org.uk
Subject: Re: [Fwd: Re: [PATCH] tpm: interrupt clear fix]

On Mon, Jul 17, 2006 at 11:35:20AM -0700, Kylene Jo Hall wrote:
> -------- Forwarded Message --------
> From: Kylene Jo Hall <kjhall@...ibm.com>
> To: linux-os (Dick Johnson) <linux-os@...logic.com>
> Cc: linux-kernel <linux-kernel@...r.kernel.org>, TPM Device Driver List
> <tpmdd-devel@...ts.sourceforge.net>, akpm@...l.org
> Subject: Re: [PATCH] tpm: interrupt clear fix
> Date: Thu, 13 Jul 2006 12:24:36 -0700
> Under stress testing I found that the interrupt is not always cleared.
> This is a bug and this patch should go into 2.6.18 and 2.6.17.x.
> 
> On Thu, 2006-07-13 at 07:45 -0400, linux-os (Dick Johnson) wrote:
> 
> > PCI devices need a final read to flush all pending writes. Whatever
> > mb() does, just hides the problem.
> 
> 
> Signed-off-by: Kylene Hall <kjhall@...ibm.com>
> ---
> 
> --- linux-2.6.18-rc1/drivers/char/tpm/tpm_tis.c	2006-07-13 14:46:39.727500500 -0500
> +++ linux-2.6.18-rc1-tpm/drivers/char/tpm/tpm_tis.c	2006-07-13 14:47:33.878884750 -0500
> @@ -424,6 +424,7 @@ static irqreturn_t tis_int_handler(int i
>  	iowrite32(interrupt,
>  		  chip->vendor.iobase +
>  		  TPM_INT_STATUS(chip->vendor.locality));
> +	ioread32(chip->vendor.iobase + TPM_INT_STATUS(chip->vendor.locality));
>  	return IRQ_HANDLED;
>  }

So does this replace the other tpm patch?  Or should we apply both of
them?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/