linux-kernel - Re: kernel/timer.c: next_timer_interrupt() strange/buggy(?) code (2.6.18-rc1-mm2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200607181450.k6IEo4Rs022388@turing-police.cc.vt.edu>
Date:	Tue, 18 Jul 2006 10:50:04 -0400
From:	Valdis.Kletnieks@...edu
To:	Michael Buesch <mb@...sch.de>
Cc:	linux-kernel@...r.kernel.org, keir@...source.com,
	Tony Lindgren <tony@...mide.com>, zach@...are.com,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andreas Mohr <andi@...x01.fht-esslingen.de>
Subject: Re: kernel/timer.c: next_timer_interrupt() strange/buggy(?) code (2.6.18-rc1-mm2)

On Tue, 18 Jul 2006 16:29:27 +0200, Michael Buesch said:

> Continue is equal to:
> 
> LOOP {
> 	/* foo */
> 	goto continue; /* == continue */
	/* What the code actually had: */
        goto found; /* Note placement of the label *AFTER* end of loop */
> 	/* foo */
> continue:
> } LOOP

found: /* out of the loop entirely */

A 'continue' drops you *at* the end of the loop. The 'goto found:' in the
original code drops you *after* the end of the loop.  One will potentially go
around for another pass, the other you're *done*.


Content of type "application/pgp-signature" skipped