linux-kernel - Re: [PATCH 1/2] Conversions from kmalloc+memset to k(z|c)alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200607190823.39571.eike-kernel@sf-tec.de>
Date:	Wed, 19 Jul 2006 08:23:39 +0200
From:	Rolf Eike Beer <eike-kernel@...tec.de>
To:	Panagiotis Issaris <takis@...umba.uhasselt.be>,
	linux-scsi@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, linux-eata@...onnect.net
Subject: Re: [PATCH 1/2] Conversions from kmalloc+memset to k(z|c)alloc

Added linux-scsi to CC as it touches drivers/scsi/

>  	/* stuff a sense request in front of our current request */
> -	pc = kmalloc (sizeof (idescsi_pc_t), GFP_ATOMIC);
> +	pc = kzalloc (sizeof (idescsi_pc_t), GFP_ATOMIC);

Please remove the space before the arguments.

>  	rq = kmalloc (sizeof (struct request), GFP_ATOMIC);

This and the one before should be "rq = kzalloc(sizeof(*rq),...);" This way 
you will always get the correct buffer size even if the type of rq changes.

Eike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/