linux-kernel - Re: [PATCH 2.6.18-rc1] Make group sorting optional in the 2.6.x kernels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20060720221106.GA5062@janus>
Date:	Fri, 21 Jul 2006 00:11:06 +0200
From:	Frank van Maarseveen <frankvm@...nkvm.com>
To:	Bill Ryder <bryder@...afx.co.nz>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.18-rc1]  Make group sorting optional in the 2.6.x kernels

On Fri, Jul 21, 2006 at 08:40:44AM +1200, Bill Ryder wrote:
[...]
> This phrase is worrying:
> 
> When there is no group id information passed downwards
> then it reverts to old behavior too.
> 
> Why would no group id information be passed?

There are a few NFS operations (or related ones such as
for file locking) which do not need that information IIRC.
"old behavior" means doing what it does _today_.

> For someone of my level of knowledge of the kernel the README does not
> convince me it will work in all situations.

NFS with AUTH_UNIX authentication cannot possibly get worse than it is
today with respect to processes in more than 16 groups. And the patch
is effectively disabled for processes in <=16 groups so I wouldn't
worry.

Anyway, a revised patch from you which no longer sorts the first 16
groups for compatibility reasons is probably easier to get merged.

-- 
Frank
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/