linux-kernel - Re: [PATCH] fs: Memory allocation cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060721143723.GB2772@slug>
Date:	Fri, 21 Jul 2006 16:37:23 +0200
From:	Frederik Deweerdt <deweerdt@...e.fr>
To:	takis@...aris.org
Cc:	linux-kernel@...r.kernel.org, rathamahata@...4.ru,
	sfrench@...ba.org, jffs-dev@...s.com, shaggy@...tin.ibm.com,
	neilb@....unsw.edu.au, trond.myklebust@....uio.no,
	reiserfs-dev@...esys.com, raven@...maw.net
Subject: Re: [PATCH] fs: Memory allocation cleanups

On Fri, Jul 21, 2006 at 01:50:55PM +0200, takis@...aris.org wrote:
> -		dnotify_req = (struct dir_notify_req *) kmalloc(
> -						sizeof(struct dir_notify_req),
> +		dnotify_req = kmalloc(sizeof(struct dir_notify_req),
>  						 GFP_KERNEL);
						^^^^^ 
Should be aligned with the kmalloc?
> -	ext_acl = (reiserfs_acl_header *) kmalloc(sizeof(reiserfs_acl_header) +
> -						  acl->a_count *
> +	ext_acl = kmalloc(sizeof(reiserfs_acl_header) + acl->a_count *
>  						  sizeof(reiserfs_acl_entry),
>  						  GFP_NOFS);
						^^^^^
This should be aligned too, I think.

Regards,
Frederik
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/