linux-kernel - Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44C26D90.4030307@s5r6.in-berlin.de>
Date:	Sat, 22 Jul 2006 20:25:20 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Tomasz Kłoczko <kloczek@...y.mif.pg.gda.pl>
CC:	Pekka J Enberg <penberg@...Helsinki.FI>,
	Panagiotis Issaris <takis@....org>,
	Jesper Juhl <jesper.juhl@...il.com>,
	Jeff Garzik <jgarzik@...ox.com>,
	Rolf Eike Beer <eike-kernel@...tec.de>,
	Panagiotis Issaris <takis@...umba.uhasselt.be>,
	linux-kernel@...r.kernel.org, len.brown@...el.com,
	chas@....nrl.navy.mil, miquel@...uba.ar, kkeil@...e.de,
	benh@...nel.crashing.org, video4linux-list@...hat.com,
	rmk+mmc@....linux.org.uk, Neela.Kolli@...enio.com,
	vandrove@...cvut.cz, adaplas@....net, thomas@...ischhofer.net,
	weissg@...nna.at, philb@....org, linux-pcmcia@...ts.infradead.org,
	jkmaline@...hut.fi, paulus@...ba.org
Subject: Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.

Tomasz Kłoczko wrote:
> On Fri, 21 Jul 2006, Stefan Richter wrote:
>> Pekka J Enberg wrote:
>>
>>> Yeah, that's what Andrew prefers but there are maintainers that disagree
>>> with that.
>>
>> Then they should change CodingStyle.
> 
> Better will be start use indent.

Style issues like "sizeof(struct foo)" versus "sizeof(*bar)" in memory 
allocation are beyond what indent can and should do.

> Coding style seems is Linux case kind of never ending story.

It's not a big deal in my limited experience, as far as there is a 
documented consensus.

> Keep one/common coding style in this case is someting not for small tool 
> but more for .. Superman/Hecules (?)
[...]

Yes. Or subsystem maintainers who didn't already could adopt the 
documented style. Or correct the document where it doesn't reflect 
consensus.
-- 
Stefan Richter
-=====-=-==- -=== =-==-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/