linux-kernel - RE: [PATCH 6/6] cpuid neatening.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1153581765.15632.1.camel@localhost.localdomain>
Date:	Sun, 23 Jul 2006 01:22:45 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Andrew Morton <akpm@...l.org>
Cc:	David Schwartz <davids@...master.com>,
	lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 6/6] cpuid neatening.


> > +static inline void __cpuid(unsigned int *eax, unsigned int *ebx,
> > +			   unsigned int *ecx, unsigned int *edx)
> > +{
> > +	/* ecx is often an input as well as an output. */
> > +	__asm__("cpuid"
> > +		: "=a" (*eax),
> > +		  "=b" (*ebx),
> > +		  "=c" (*ecx),
> > +		  "=d" (*edx)
> > +		: "0" (*eax), "2" (*ecx));
> > +}
> > +
> 
> 	Shouldn't that be:
> 
> __asm__("cpuid"
> : "+a" (*eax),
>   "=b" (*ebx),
>   "+c" (*ecx),
>   "=d" (*edx)
> );

Perhaps?  I copied the existing code...

Rusty.
-- 
Help! Save Australia from the worst of the DMCA: http://linux.org.au/law

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/