linux-kernel - Re: [RFC/PATCH] revoke/frevoke system calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20060721171922.602706f9.akpm@osdl.org>
Date:	Fri, 21 Jul 2006 17:19:22 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Pekka J Enberg <penberg@...Helsinki.FI>
Cc:	alan@...rguk.ukuu.org.uk, tytso@....edu,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [RFC/PATCH] revoke/frevoke system calls

On Thu, 20 Jul 2006 15:07:30 +0300 (EEST)
Pekka J Enberg <penberg@...Helsinki.FI> wrote:

> From: Pekka Enberg <penberg@...helsinki.fi>
> 
> This patch implements the revoke(2) and frevoke(2) system calls for all
> types of files.
>
> ...
>
> -	file = fget_light(fd, &fput_needed);
> +	file = fget(fd);

This is sad.

> +static int revoke_files(struct task_struct *owner, struct inode *inode,
> +			struct file *exclude, struct list_head *to_close)
> +{
> ...
> +	spin_lock(&files->file_lock);
> ...
> +		revoked = kmalloc(sizeof(*revoked), GFP_KERNEL);

This is bad.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/