lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.58.0607221801240.30557@twin.jikos.cz>
Date:	Sat, 22 Jul 2006 18:15:58 +0200 (CEST)
From:	Jiri Kosina <jikos@...os.cz>
To:	len.brown@...el.com
cc:	linux-acpi@...el.com, linux-kernel@...r.kernel.org
Subject: [PATCH] ACPI - change GFP_ATOMIC to GFP_KERNEL for non-atomic
 allocation

Hi,

drivers/acpi/pci_link.c::acpi_pci_link_set() sets the GFP_ATOMIC for
kmalloc() allocation for no first-sight obvious reason; as far as I can
see this is always called outside the atomic/interrupt context, so
GFP_KERNEL allocation should be used instead.

If applicable, please apply

Signed-off-by: Jiri Kosina <jikos@...os.cz>

--- drivers/acpi/pci_link.c.orig	2006-07-15 21:00:43.000000000 +0200
+++ drivers/acpi/pci_link.c	2006-07-22 17:45:11.000000000 +0200
@@ -318,7 +318,7 @@ static int acpi_pci_link_set(struct acpi
 	if (!link || !irq)
 		return_VALUE(-EINVAL);
 
-	resource = kmalloc(sizeof(*resource) + 1, GFP_ATOMIC);
+	resource = kmalloc(sizeof(*resource) + 1, GFP_KERNEL);
 	if (!resource)
 		return_VALUE(-ENOMEM);
 
 

-- 
JiKos.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ