linux-kernel - Re: [RFC][PATCH] A generic boolean (version 4)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20060723141319.7eed99eb.pj@sgi.com>
Date:	Sun, 23 Jul 2006 14:13:19 -0700
From:	Paul Jackson <pj@....com>
To:	ricknu-0@...dent.ltu.se
Cc:	linux-kernel@...r.kernel.org, akpm@...l.org, jeff@...zik.org,
	adobriyan@...il.com, vlobanov@...akeasy.net,
	jengelh@...ux01.gwdg.de, getshorty_@...mail.com,
	pwil3058@...pond.net.au, mb@...sch.de, penberg@...helsinki.fi,
	stefanr@...6.in-berlin.de, larsbj@...lik.net
Subject: Re: [RFC][PATCH] A generic boolean (version 4)

The defines of false and true to be themselves are going to cause a
thousand code readers to say "wtf?".  How about a comment, as in:

 enum {
 	false	= 0,
 	true	= 1
 };
+
+/* Let any other #if[n]def's on false/true presume they're defined */
 #define false false
 #define true true 
 

===

On second thought, I just grep'd the entire kernel with:
	grep -E '#ifn*def.*(false|true)'
and only found exactly one other such #ifdef construct:

  drivers/media/video/cpia2/cpia2.h:
    #ifndef true
    #define true 1
    #define false 0
    #endif

Perhaps we should just drop the cpia2.h defines, and drop
the defines of false/true to be themselves.  And drop my
comment ;).

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@....com> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/