linux-kernel - Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44C392EA.1080101@s5r6.in-berlin.de>
Date:	Sun, 23 Jul 2006 17:16:58 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Jeff Garzik <jgarzik@...ox.com>
CC:	Tomasz Kłoczko <kloczek@...y.mif.pg.gda.pl>,
	Pekka J Enberg <penberg@...Helsinki.FI>,
	Panagiotis Issaris <takis@....org>,
	Jesper Juhl <jesper.juhl@...il.com>,
	Rolf Eike Beer <eike-kernel@...tec.de>,
	Panagiotis Issaris <takis@...umba.uhasselt.be>,
	linux-kernel@...r.kernel.org, len.brown@...el.com,
	chas@....nrl.navy.mil, miquel@...uba.ar, kkeil@...e.de,
	benh@...nel.crashing.org, video4linux-list@...hat.com,
	rmk+mmc@....linux.org.uk, Neela.Kolli@...enio.com,
	vandrove@...cvut.cz, adaplas@....net, thomas@...ischhofer.net,
	weissg@...nna.at, philb@....org, linux-pcmcia@...ts.infradead.org,
	jkmaline@...hut.fi, paulus@...ba.org
Subject: Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.

Jeff Garzik wrote:
> Tomasz Kłoczko wrote:
>> Moment .. are you want to say something like "keep commont coding 
>> style can't be maintained by tool" ?

Yes and no.

>> Even if indent watches on to small coding style emenets still I don't 
>> see why using this tool isn't one of the current ement of release 
>> procedure (?).
> 
> indent isn't perfect, _especially_ where C99 comes into the picture.
> 
> And running indent across the tree pre-release would (a) create a ton of 
> noise before each release, and (b) undo perfectly valid, readable 
> formatting.
> 
> scripts/Lindent exists and gets used, but it is not perfect.

Tomasz,

yes, we have scripts/Lindent, but it cannot and is not supposed to solve 
all style issues. Coding style is about _much_ more than whitespace. It 
includes sensible names, usage of language features...

Furthermore, much of this thread revolved around style issues where a 
common coding style is not fully established in the first place.
-- 
Stefan Richter
-=====-=-==- -=== =-===
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/