linux-kernel - Re: cc-version not available to change EXTRA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20060723175111.GA22861@mars.ravnborg.org>
Date:	Sun, 23 Jul 2006 19:51:11 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Olaf Hering <olh@...e.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: cc-version not available to change EXTRA_CFLAGS

On Wed, Jul 19, 2006 at 11:02:04AM +0200, Olaf Hering wrote:
>  On Sat, Jan 21, Olaf Hering wrote:
> 
> > 
> > I want to add a gcc version check for reiserfs, on akpms request.
> 
> This debug patch still doesnt work in 2.6.18-rc2:
> 
> 
> make -kj 14 O=$O
> 
> scripts/gcc-version.sh: line 11: _c_flags: command not found
> scripts/gcc-version.sh: line 12: _c_flags: command not found
> + '[' 0000 -lt 0500 ']'
> + echo -O1

Fixed by following patch. Please consider using: cc-ifversion (see
Documentation/kbuild/makefiles.txt

	Sam

commit 045cfddb5f89722259c90fb742e201d289d94092
Author: Sam Ravnborg <sam@...s.ravnborg.org>
Date:   Sun Jul 23 19:49:45 2006 +0200

    kbuild: always use $(CC) for $(call cc-version)
    
    The possibility to specify an optional parameter did not work out as
    expected and it was not used - so remove the possibility.
    
    Signed-off-by: Sam Ravnborg <sam@...nborg.org>

diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
index 7a18353..dbb20a6 100644
--- a/scripts/Kbuild.include
+++ b/scripts/Kbuild.include
@@ -81,8 +81,7 @@ cc-option-align = $(subst -functions=0,,
 
 # cc-version
 # Usage gcc-ver := $(call cc-version, $(CC))
-cc-version = $(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh \
-              $(if $(1), $(1), $(CC)))
+cc-version = $(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh $(CC))
 
 # cc-ifversion
 # Usage:  EXTRA_CFLAGS += $(call cc-ifversion, -lt, 0402, -O1)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/