[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.BSO.4.63.0607231955310.10018@rudy.mif.pg.gda.pl>
Date: Sun, 23 Jul 2006 20:09:45 +0200 (CEST)
From: Tomasz Kłoczko <kloczek@...y.mif.pg.gda.pl>
To: Stefan Richter <stefanr@...6.in-berlin.de>
cc: Jeff Garzik <jgarzik@...ox.com>,
Pekka J Enberg <penberg@...Helsinki.FI>,
Panagiotis Issaris <takis@....org>,
Jesper Juhl <jesper.juhl@...il.com>,
Rolf Eike Beer <eike-kernel@...tec.de>,
Panagiotis Issaris <takis@...umba.uhasselt.be>,
linux-kernel@...r.kernel.org, len.brown@...el.com,
chas@....nrl.navy.mil, miquel@...uba.ar, kkeil@...e.de,
benh@...nel.crashing.org, video4linux-list@...hat.com,
rmk+mmc@....linux.org.uk, Neela.Kolli@...enio.com,
vandrove@...cvut.cz, adaplas@....net, thomas@...ischhofer.net,
weissg@...nna.at, philb@....org, linux-pcmcia@...ts.infradead.org,
jkmaline@...hut.fi, paulus@...ba.org
Subject: Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
On Sun, 23 Jul 2006, Stefan Richter wrote:
[..]
> Tomasz,
>
> yes, we have scripts/Lindent, but it cannot and is not supposed to solve all
> style issues. Coding style is about _much_ more than whitespace. It includes
> sensible names, usage of language features...
Yes .. I know about this but it can allow plug some subset of current
coding style problems. Prodicing Perfect-Word in sigle step is probably
impossible but start this step by step will be probably rationale :)
Look below is it not will be good now start:
1) review current tree for fix/change code allow pass throw indent without
errors and commit all neccessary for this changes,
2) produce diff for whole source tree and start disscuss on "are
current Lindent script indentation rules are correct or not ?",
3) after prepare acceptable by Linus indent rules set setup kind of
moratory for all (co)developers for submitting indentation changes
during normal changes submission (month or even half year but IMo
shorter will be better),
4) aftter passing moratory date Linus can commit all pending changes in
single commit.
??
kloczek
--
-----------------------------------------------------------
*Ludzie nie mają problemów, tylko sobie sami je stwarzają*
-----------------------------------------------------------
Tomasz Kłoczko, sys adm @zie.pg.gda.pl|*e-mail: kloczek@...y.mif.pg.gda.pl*
Powered by blists - more mailing lists