linux-kernel - [RT] rt priority losing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1153755660.4002.137.camel@localhost.localdomain>
Date:	Mon, 24 Jul 2006 11:41:00 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	"Duetsch, Thomas LDE1" <thomas.duetsch@...mens.com>
Subject: [RT] rt priority losing

Ingo or Tglx,

It has come to my attention that the dynamic hrtimer softirq can lose a
boosted priority.  That is, if a softirq is running while a timeout
happens, and the call back is of lower priority than the currently
running hrtimer softirq, the timer interrupt will still lower the
hrtimer softirq.

Here's the problem code:

static void wakeup_softirqd_prio(int softirq, int prio)
{
	/* Interrupts are disabled: no need to stop preemption */
	struct task_struct *tsk = __get_cpu_var(ksoftirqd[softirq].tsk);

	if (tsk) {
		if (tsk->normal_prio != prio) {
			struct sched_param param;

			param.sched_priority = MAX_RT_PRIO-1 - prio;
			setscheduler(tsk, -1, SCHED_FIFO, &param);
		}
		if(tsk->state != TASK_RUNNING)
			wake_up_process(tsk);
	}
}

So, tsk could be softirqd-hrmono and we lower the priority. (only
normal_prio is checked versus prio).

So this can be a problem, if the softirq function holds a lock of a high
priority task, and is running boosted.  If another timer goes off with a
lower priority, we can lower the priority of the softirqd and lose the
inherited priority that it was running at.

-- Steve

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/